1
Vote

Invalid PDU processing not currently robust against invalid lengths

description

The current implementation of JamaaTech.Smpp.Net.Lib.StreamParser.WaitPdu (.\jamaasmpp_ad35e32d9dfe\JamaaTech.SMPP.Net.Lib\StreamParser.cs) is not robust against invalid received headers, especially where the CommandLength is excessively large.

In general more exception handling, and a test against Int32.MaxValue, is needed when attempting to recover some data in the existing exception handling code.

(BTW I have converted this whole project to VB.NET, which is why I've documented changes and not just made them as C# patches.)

comments