1
Vote

Default encoding misses 255

description

The existing code in JamaaTech.Smpp.Net.Lib.Util.SMSCDefaultEncoding.BuildTable (.\jamaasmpp_ad35e32d9dfe\JamaaTech.SMPP.Net.Lib\Util\SmscDefaultEncoding.cs):
            //This table is used for reverse lookup
            vDefaultReverseTable = new byte[byte.MaxValue];
            ...
            for (; index < byte.MaxValue; ++index)
should be
            //This table is used for reverse lookup
            vDefaultReverseTable = new byte[byte.MaxValue+1];
            ...
            for (; index <= byte.MaxValue; ++index)

comments